From f30535055ff9dec95916375cfca05c62b5757daf Mon Sep 17 00:00:00 2001 From: Pablo Baleztena Date: Wed, 23 Oct 2024 23:54:46 -0300 Subject: [PATCH] [fabric/validations] Update string sanitization to return undefined for non-string values --- packages/fabric/validations/string/sanitize-string.test.ts | 4 ++-- packages/fabric/validations/string/sanitize-string.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/fabric/validations/string/sanitize-string.test.ts b/packages/fabric/validations/string/sanitize-string.test.ts index a023af4..4a9bcd6 100644 --- a/packages/fabric/validations/string/sanitize-string.test.ts +++ b/packages/fabric/validations/string/sanitize-string.test.ts @@ -17,13 +17,13 @@ describe("Sanitize String", () => { test("Given a number value it should convert it to a string", () => { const sanitized = parseAndSanitizeString(123); - expect(sanitized).toBe("123"); + expect(sanitized).toBe(undefined); }); test("Given a boolean value it should convert it to a string", () => { const sanitized = parseAndSanitizeString(true); - expect(sanitized).toBe("true"); + expect(sanitized).toBe(undefined); }); test("Given a null value it should return null", () => { diff --git a/packages/fabric/validations/string/sanitize-string.ts b/packages/fabric/validations/string/sanitize-string.ts index f3ec9f6..9afc9ce 100644 --- a/packages/fabric/validations/string/sanitize-string.ts +++ b/packages/fabric/validations/string/sanitize-string.ts @@ -7,8 +7,8 @@ import { isNullish } from "../nullish/is-nullish.ts"; export function parseAndSanitizeString( value: unknown, ): string | undefined { - if (isNullish(value)) return undefined; - return stripLow((String(value)).trim()); + if (isNullish(value) || typeof value != "string") return undefined; + return stripLow(value).trim(); } // deno-lint-ignore no-control-regex